Merged
Conversation
- Replaces make-container mixin's padding-x param with gutter to match naming - Changes value of container padding variable to match grid gutter width variable - Uses local CSS variable for container padding Fixes #31642
Member
|
I changed that in #28517 after @ysds' comment #28517 (review) The paddings for containers or navbars are (imo) indeed a little too much in this PR, eg. |
Member
Author
|
Oh yeah, duh, I forgot to divide it by 2 to match the |
Member
Author
|
Is this okay to get into an Alpha 2 in the next week or so, @twbs/css-review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grid container, row, and column padding/margin should always match. I missed this in my reviews and testing, unless there's uh something else I missed. 😅
Fixes #31642
/cc @MartijnCuppens directly since the original PR at #29146 changed this