Skip to content

ensure hidePrevented.bs.modal can be prevented#31696

Merged
XhmikosR merged 8 commits intotwbs:v4-devfrom
joakimriedel:joakimriedel/defaultPrevented
Sep 21, 2020
Merged

ensure hidePrevented.bs.modal can be prevented#31696
XhmikosR merged 8 commits intotwbs:v4-devfrom
joakimriedel:joakimriedel/defaultPrevented

Conversation

@joakimriedel
Copy link
Copy Markdown

@joakimriedel joakimriedel commented Sep 18, 2020

Fixes #31615

Copy link
Copy Markdown
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @joakimriedel 👍

Just a few modifications and it'll be good to go

Comment thread js/tests/unit/modal.js
Comment thread js/tests/unit/modal.js
@joakimriedel
Copy link
Copy Markdown
Author

Btw @Johann-S I did not commit the dist folder, assumed that is done somehow by CI?

@Johann-S
Copy link
Copy Markdown
Member

yep we build the dist folder before each release 👌

@XhmikosR XhmikosR changed the title ensure hidePrevented.bs.modal can be prevented ensure hidePrevented.bs.modal can be prevented Sep 21, 2020
@XhmikosR XhmikosR merged commit b0a0c56 into twbs:v4-dev Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in modal.js: defaultPrevented called on jQuery.Event instead of isDefaultPrevented()

3 participants