Merged
Conversation
XhmikosR
reviewed
Sep 30, 2020
XhmikosR
force-pushed
the
v4-backports-mdo
branch
from
0783f63 to
116d138
Compare
mdo
force-pushed
the
v4-backports-mdo
branch
from
116d138 to
fc7d5a3
Compare
Member
Author
|
Updated @XhmikosR, should be good to go now! |
XhmikosR
approved these changes
Oct 1, 2020
Member
XhmikosR
left a comment
XhmikosR
left a comment
There was a problem hiding this comment.
LGTM but I'd like another approval from @twbs/css-review for the Sass changes :)
|
Please use comments for |
Member
|
They are too verbose and not really needed.
…On Sun, Oct 4, 2020, 02:09 Ihor Zenich ***@***.***> wrote:
Please use comments for .text-break from this commit: e501897
<e501897>
for right correct explanation what are they doing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31793 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNMGN3XWA3VWKY2O3G3SI6VLBANCNFSM4R6INRJQ>
.
|
Ok, but please then at least remove current |
Member
|
Friendly ping @twbs/css-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thupdates: Inheritfont-weight: boldthat comes from user agent stylesheets. #30781: Reboot's th updates.text-breakchanges to dropoverflow-wrapand useword-wraponce again (closes Fix text-break in IE and Edge Legacy #31727)