Add callouts about using light colors ideally on a dark background#32040
Merged
patrickhlauke merged 3 commits intomainfrom Nov 2, 2020
Merged
Add callouts about using light colors ideally on a dark background#32040patrickhlauke merged 3 commits intomainfrom
patrickhlauke merged 3 commits intomainfrom
Conversation
Contributor
|
With #30044 merged a few days ago, it might be quite trivial to handle backgrounds (but would require to use some kind of containers to apply backgrounds). However the callout is a good idea :) |
ffoodd
approved these changes
Nov 2, 2020
Member
Author
|
Just realised we should probably do the same for https://v5.getbootstrap.com/docs/5.0/helpers/colored-links/ ... i'll add another commit here |
Member
|
Would be very nice to add a background element around them if needed based on the contrast colors. A callout like this feels unnecessary IMO, but I'm down for whatever. |
Member
Author
|
let's do callout just now, and then somebody cleverer than me can work out how to do a conditional bit of light vs dark background |
Member
|
@patrickhlauke this needs a manual backport, can you do it please and ping me? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
would be even better to show those buttons on a dark background, but i assume that'd require a lot more logic behind the scenes (to only show the outline buttons that are contrasty enough against white on a white background, and the others on a dark background)