Skip to content

Add callouts about using light colors ideally on a dark background#32040

Merged
patrickhlauke merged 3 commits intomainfrom
patrickhlauke-docs-buttons-outline-callout
Nov 2, 2020
Merged

Add callouts about using light colors ideally on a dark background#32040
patrickhlauke merged 3 commits intomainfrom
patrickhlauke-docs-buttons-outline-callout

Conversation

@patrickhlauke
Copy link
Copy Markdown
Member

would be even better to show those buttons on a dark background, but i assume that'd require a lot more logic behind the scenes (to only show the outline buttons that are contrasty enough against white on a white background, and the others on a dark background)

@ffoodd
Copy link
Copy Markdown
Contributor

ffoodd commented Nov 2, 2020

With #30044 merged a few days ago, it might be quite trivial to handle backgrounds (but would require to use some kind of containers to apply backgrounds). However the callout is a good idea :)

@patrickhlauke
Copy link
Copy Markdown
Member Author

Just realised we should probably do the same for https://v5.getbootstrap.com/docs/5.0/helpers/colored-links/ ... i'll add another commit here

@patrickhlauke patrickhlauke changed the title Add callout about using light colors ideally on a dark background Add callouts about using light colors ideally on a dark background Nov 2, 2020
@mdo
Copy link
Copy Markdown
Member

mdo commented Nov 2, 2020

Would be very nice to add a background element around them if needed based on the contrast colors. A callout like this feels unnecessary IMO, but I'm down for whatever.

@patrickhlauke
Copy link
Copy Markdown
Member Author

let's do callout just now, and then somebody cleverer than me can work out how to do a conditional bit of light vs dark background

@patrickhlauke patrickhlauke merged commit 6682bba into main Nov 2, 2020
@patrickhlauke patrickhlauke deleted the patrickhlauke-docs-buttons-outline-callout branch November 2, 2020 20:39
@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Nov 3, 2020

@patrickhlauke this needs a manual backport, can you do it please and ping me?

@patrickhlauke
Copy link
Copy Markdown
Member Author

@XhmikosR done - #32054

XhmikosR pushed a commit that referenced this pull request Nov 3, 2020
Add callouts about using light colors ideally on a dark background
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants