Remove popover-arrow margin to fix alignment of the arrow#32787
Merged
Remove popover-arrow margin to fix alignment of the arrow#32787
Conversation
ffoodd
approved these changes
Jan 14, 2021
Contributor
ffoodd
left a comment
ffoodd
left a comment
There was a problem hiding this comment.
LGTM, didn't see anything weird either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Near as I can tell, the changes from #25062 are no longer needed. This could be because of something that changed on our end or in Popper with the move to v2. Either way, these cause an issue in at least Safari for the arrow alignment. I dropped it entirely and see neither the issue in the reference PR, nor the issue in #32485.
Closes #32485.