Remove custom fallbackPlacements from the dropdown#32843
Merged
Conversation
034253c to
b30be68
Compare
Member
|
@mdo how do we proceed with this? |
Member
|
@XhmikosR @rohit2sharma95 I don't see the issue in #32648 in our production site at https://getbootstrap.com/docs/5.0/components/dropdowns/#menu-alignment. Should I be looking in a particular browser or OS? |
Member
|
Actually I just saw the issue in another PR on the RTL cheatsheet: https://deploy-preview-32986--twbs-bootstrap.netlify.app/docs/5.0/examples/cheatsheet-rtl/. |
mdo
approved these changes
Feb 8, 2021
This was referenced Feb 22, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32648
Why to remove
fallbackPlacementsoption from the dropdown:fallbackPlacementsright now.Why to keep
fallbackPlacementsoption in Tooltip/Popover:Because it provides better placements to Tooltip/Popover IMO (Since there is no official special handing for the placement of Tooltip/Popover on the edges, like-
dropstartanddropendfor dropdowns). Popper's default value forfallbackPlacementsis [oppositePlacement] it means:More in the description of #32437. So its better to have more fallback placements by default for Tooltip/Popover.
And the flip modifier can be added with
fallbackPlacementsby thepopperConfigoption in case the same issue like #32384 is caused with dropdowns as well (Which is rare in case of dropdowns IMO).