Skip to content

Prevent toast autohiding if focusing or hovering#33221

Merged
XhmikosR merged 2 commits intotwbs:mainfrom
RyanBerliner:toast-interaction
May 11, 2021
Merged

Prevent toast autohiding if focusing or hovering#33221
XhmikosR merged 2 commits intotwbs:mainfrom
RyanBerliner:toast-interaction

Conversation

@RyanBerliner
Copy link
Copy Markdown
Contributor

@RyanBerliner RyanBerliner commented Feb 28, 2021

resolves #32820

TODO:

  • Land it after some of the refactoring PRs so that we don't need to adapt bundlewatch

@RyanBerliner RyanBerliner requested a review from a team as a code owner February 28, 2021 20:33
@RyanBerliner RyanBerliner force-pushed the toast-interaction branch 2 times, most recently from 128b504 to 2a63a7b Compare March 19, 2021 20:19
Comment thread js/src/toast.js Outdated
Comment thread js/src/toast.js Outdated
Comment thread js/src/toast.js Outdated
Comment thread js/src/toast.js Outdated
Comment thread js/tests/unit/toast.spec.js Outdated
Comment thread js/tests/unit/toast.spec.js Outdated
Comment thread js/src/toast.js Outdated
Comment thread js/src/toast.js Outdated
Comment thread js/tests/unit/toast.spec.js Outdated
Comment thread js/tests/unit/toast.spec.js Outdated
@GeoSot GeoSot self-requested a review April 26, 2021 22:33
@GeoSot
Copy link
Copy Markdown
Member

GeoSot commented May 10, 2021

@RyanBerliner please rebase your branch.

@XhmikosR XhmikosR changed the title prevent toast autohiding if focusing or hovering Prevent toast autohiding if focusing or hovering May 11, 2021
@XhmikosR XhmikosR merged commit 9c3ab65 into twbs:main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toasts should not autohide when hovered or when focus is inside

5 participants