Skip to content

Added rounded border support for IE#351

Closed
dmyers wants to merge 1 commit intotwbs:masterfrom
dmyers:730bc9c72f7f20dadd61b14d3e2200a01cd03527
Closed

Added rounded border support for IE#351
dmyers wants to merge 1 commit intotwbs:masterfrom
dmyers:730bc9c72f7f20dadd61b14d3e2200a01cd03527

Conversation

@dmyers
Copy link
Copy Markdown

@dmyers dmyers commented Oct 1, 2011

No description provided.

@tbassetto
Copy link
Copy Markdown

I can't find any proof that IE supports -ms-border-radius. When they introduced IE9, they made it clear that border-radius was working without vendor prefix.

@dmyers
Copy link
Copy Markdown
Author

dmyers commented Oct 1, 2011

Yes it appears you are right. I had thought that was needed a while back before IE9, but oh well.
http://jsfiddle.net/4bTMk/

When I viewed the bootstrap docs in IE9, I didn't see them rounded which made me think that was needed.
http://jsfiddle.net/2tBEH/

@dmyers
Copy link
Copy Markdown
Author

dmyers commented Oct 1, 2011

Okay I finally found what is causing it and it is this line:
https://github.com/twitter/bootstrap/blob/master/lib/patterns.less#L596

@dmyers dmyers closed this Oct 1, 2011
@dmyers dmyers reopened this Oct 3, 2011
@dmyers
Copy link
Copy Markdown
Author

dmyers commented Oct 3, 2011

I didn't meant to close it I was just hoping to get feedback on what to do.

@fat are the :root lines meant to block IE from rounding the buttons?

@fat
Copy link
Copy Markdown
Member

fat commented Oct 4, 2011

mark and i opted to not have rounded corners in ie because of a gradient clipping issue.

@mdo
Copy link
Copy Markdown
Member

mdo commented Oct 4, 2011

Yup, it's in the comments for the Less files. Gradients bleed through in IE9 which sucks. So we used some jank-a-lank to get around that for no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants