Skip to content

Tooltip: remove leftover method #35440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XhmikosR merged 2 commits into from
Dec 1, 2021
Merged

Tooltip: remove leftover method #35440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7675b87
remove left over method after #32692 merge
GeoSot Nov 25, 2021
66f080e
Merge branch 'main' into gs/remove-tip-left-overs-after-template-factory
XhmikosR Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions js/src/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,18 +398,6 @@ class Tooltip extends BaseComponent {
return this._resolvePossibleFunction(this._config.title) || this._element.getAttribute('title')
}

updateAttachment(attachment) {
if (attachment === 'right') {
return 'end'
}

if (attachment === 'left') {
return 'start'
}

return attachment
}

// Private
_initializeOnDelegatedTarget(event, context) {
return context || this.constructor.getOrCreateInstance(event.delegateTarget, this._getDelegateConfig())
Expand Down
34 changes: 0 additions & 34 deletions js/tests/unit/tooltip.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,40 +1083,6 @@ describe('Tooltip', () => {
})
})

describe('updateAttachment', () => {
it('should use end class name when right placement specified', done => {
fixtureEl.innerHTML = '<a href="#" rel="tooltip" title="Another tooltip">'

const tooltipEl = fixtureEl.querySelector('a')
const tooltip = new Tooltip(tooltipEl, {
placement: 'right'
})

tooltipEl.addEventListener('inserted.bs.tooltip', () => {
expect(tooltip.getTipElement()).toHaveClass('bs-tooltip-auto')
done()
})

tooltip.show()
})

it('should use start class name when left placement specified', done => {
fixtureEl.innerHTML = '<a href="#" rel="tooltip" title="Another tooltip">'

const tooltipEl = fixtureEl.querySelector('a')
const tooltip = new Tooltip(tooltipEl, {
placement: 'left'
})

tooltipEl.addEventListener('inserted.bs.tooltip', () => {
expect(tooltip.getTipElement()).toHaveClass('bs-tooltip-auto')
done()
})

tooltip.show()
})
})

describe('setContent', () => {
it('should do nothing if the element is null', () => {
fixtureEl.innerHTML = '<a href="#" rel="tooltip" title="Another tooltip">'
Expand Down