Skip to content

Popover/Tooltip: Fix vertical alignment on arrow of tip elements #35527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XhmikosR merged 3 commits into from
Dec 21, 2021
Merged

Popover/Tooltip: Fix vertical alignment on arrow of tip elements #35527

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32d6615
Popover/Tooltip: Fix vertical alignment on arrow of tip elements
GeoSot Dec 10, 2021
2cb9927
Merge branch 'main' into gs/achieve-vertical-alignment-on-popovers
XhmikosR Dec 21, 2021
ac5b713
Update tooltip.js
XhmikosR Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion js/src/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,16 @@ class Tooltip extends BaseComponent {
options: {
element: `.${this.constructor.NAME}-arrow`
}
},
{
name: 'preSetPlacement',
enabled: true,
phase: 'beforeMain',
fn: data => {
// Pre-set Popper's placement attribute in order to read the arrow sizes properly.
// Otherwise, Popper mixes up the width and height dimensions since the initial arrow style is for top placement
this._getTipElement().setAttribute('data-popper-placement', data.state.placement)
}
}
]
}
Expand Down Expand Up @@ -624,7 +634,6 @@ class Tooltip extends BaseComponent {
}

// Static

static jQueryInterface(config) {
return this.each(function () {
const data = Tooltip.getOrCreateInstance(this, config)
Expand Down