Skip to content

Update docs syntax colors head of dark mode#35984

Merged
mdo merged 2 commits intomainfrom
dancing-queen
Apr 12, 2022
Merged

Update docs syntax colors head of dark mode#35984
mdo merged 2 commits intomainfrom
dancing-queen

Conversation

@mdo
Copy link
Copy Markdown
Member

@mdo mdo commented Mar 10, 2022

This PR updates the docs syntax CSS to what I use on <markdotto.com> ahead of shipping dark mode, which requires wider usage of CSS variables. Not a huge departure, and still something I'd like to tweak over time mind you. Open to feedback here still.

/cc @XhmikosR


Cherry-picked from #35857 at abba53d (which is why I named this branch dancing-queen lol).

@mdo mdo requested a review from a team as a code owner March 10, 2022 02:05
@XhmikosR
Copy link
Copy Markdown
Member

Are you sure you are not missing any classes compared to before? This is not the same as Jekyll which is one of the reasons I had kept the comments. I'm fine with dropping the comments assuming we still include all classes.

Also, note that the new colors are not WCAG2AA valid and I had spent some time to make them valid before :/

PS. we use the same file in blog and icons too so it probably makes sense to fix any issues before landing this and backporting it.

@patrickhlauke
Copy link
Copy Markdown
Member

the problematic colour combinations seem to be centered around the code highlighting styles

@mdo
Copy link
Copy Markdown
Member Author

mdo commented Mar 10, 2022

Good callout, I didn't realize those were so bad. I've darkened a couple colors to fix the most obvious issues. Going to double check the rest shortly.

@patrickhlauke
Copy link
Copy Markdown
Member

confirming that i don't note any immediately apparent contrast issues on https://deploy-preview-35984--twbs-bootstrap.netlify.app/

@mdo
Copy link
Copy Markdown
Member Author

mdo commented Apr 11, 2022

Going to merge as-is for now and we can iterate on colors if needed in future updates.

@mdo mdo merged commit e206a60 into main Apr 12, 2022
@mdo mdo deleted the dancing-queen branch April 12, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants