Merged
Conversation
Member
|
Not sure I follow what the suggestion here is other than simplifying some HTML? |
Member
Author
|
Yes, that's it, it's only a standardization for the drop-* family HTML. I just thought that it would be easier for newcomers but it's not mandatory. |
mdo
approved these changes
Apr 13, 2022
mdo
force-pushed
the
main-lmp-dropstart-fix
branch
from
0f49f10 to
906250d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #28997.
It's been a long time, but following what I read, the removal of nesting for
.dropstartwas something that was asked (and I found that a bit weird by reading the actual code done in #23860).I know that the dropstart component works well atm and it shouldn't change, but I was asking myself if a solution like this could potentially work for you. I couldn't see any breaking change with my visual checks and my tests with nesting.
If you accept this changes and as it changes the html code, I don't know if there is anything more to change.