Merged
Conversation
77 tasks
louismaximepiton
force-pushed
the
main-lmp-docs-fixes
branch
from
b867665 to
5b355fa
Compare
GeoSot
reviewed
May 19, 2022
louismaximepiton
force-pushed
the
main-lmp-docs-fixes
branch
from
ca6e95c to
f7b83ca
Compare
mdo
approved these changes
May 20, 2022
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Thank you for the detailed commits and PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the issues concerning the CSS part, we encountered with @julien-deramond.
The commits can be splited if needed or wanted or even be in another PR. I'm open to every comment that could help fix these issues.
Issues tackled by this PR:
New helper with (47a4d3d)
Using the new helper in doc and examples whenever it's feasible.
tabindex="-1"with (73a86e8)Remove the access, for keyboard users, to the input that is unused and here to avoid a Safari bug (#36176 (comment))
Scrollspy examples with (651d66e)
Change scrollspy code examples to be closer to the real implementation
Re-order js tables in doc with (6c9b30a)
Re-ordering alphabetically js tables in doc to be more comprehensive and user friendly (except hide with hidden to keep logic)
Parcel with (f7b83ca)
Fix some doc inconsistencies in
parcel.md.Align center with (212ffe0)
Align center almost all the texts in examples in Category
Layout. I found it more visual and followed the CSS-grid example. If these are approved, it might be good to backport it to flex utilities, etc...Re-order helpers with (eb4dc49)
Re-ordering alphabetically helpers. if these changes are approved, might be great to bring it back to other main categories such as
Layout,Forms, etc...