Skip to content

Adding to "customize/sass/#add-to-map" info about utilities#37319

Closed
bachelorcthulhu wants to merge 5 commits intotwbs:mainfrom
bachelorcthulhu:documention-scss-clarfify-about-map-and-utilities
Closed

Adding to "customize/sass/#add-to-map" info about utilities#37319
bachelorcthulhu wants to merge 5 commits intotwbs:mainfrom
bachelorcthulhu:documention-scss-clarfify-about-map-and-utilities

Conversation

@bachelorcthulhu
Copy link
Copy Markdown

@bachelorcthulhu bachelorcthulhu commented Oct 13, 2022

Description

Added example of generating utilities with custom colors, that user added to map. Also added reference to "Color" page - where is located explanation of utilities and another example

Motivation & Context

At adding new colors to map, there will be available only bg-custom-color and link-custom-color classes. Right now, that page has no information about adding new classes and utilities, so user maybe confused, why he can't use custom color to background.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

https://deploy-preview-37319--twbs-bootstrap.netlify.app/docs/5.2/customize/sass/#add-to-map

At adding new colors to map, there will be available only bg-custom-color and link-custom-color classes. Right now, that page has no information about adding new classes and utilities, so user maybe confused, why he can't use custom color to background.
@bachelorcthulhu bachelorcthulhu marked this pull request as ready for review October 14, 2022 14:25
julien-deramond and others added 2 commits October 14, 2022 21:19
Fixed relative link of "/customize/color#generating-utilities"
Grammar fixed
@bachelorcthulhu bachelorcthulhu changed the title About adding to map custom colors and utilities Adding to "customize/sass/#add-to-map" info about utilities Oct 15, 2022
@mdo
Copy link
Copy Markdown
Member

mdo commented Oct 30, 2022

Thanks for this, but this doesn't make much sense as written and the code is off given the tabbing. We're replacing a lot of that section of the docs with #37398 though too, so closing this out. If you still want to suggest a change there, check that PR out and see if it still makes sense to mention something here.

@mdo mdo closed this Oct 30, 2022
@bachelorcthulhu bachelorcthulhu deleted the documention-scss-clarfify-about-map-and-utilities branch October 31, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants