ref: refactor getSelector not to be exported#37438
Merged
Conversation
julien-deramond
approved these changes
Nov 7, 2022
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
LGTM. Just had a comment/question that can be treated without a need to re-ask for a review.
GeoSot
force-pushed
the
gs/ref-get-selector
branch
from
5c900eb to
89aaa45
Compare
Member
|
This broke BrowserStack tests even more: https://github.com/twbs/bootstrap/actions/runs/3410515034/jobs/5673563662 |
Member
Author
|
Wasn't this but as it is being said, we have to resolve asap the BrowserStack problem or to check of any alternatives |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a minor refactor in the scope of Selector-engine. Method
getSelectordoesn't need to be exported as it is used localyType of changes
Checklist
npm run lint)