Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I'm very noob to this github merging and forking stuff. |
Member
|
Yep don't worry. We'll take a look at your PR asap. Thanks for opening it btw. |
mdo
approved these changes
Dec 26, 2022
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Confirmed in the demos that this is better, thanks!
Member
|
This needs a rebase, and I'd like to hear @GeoSot's opinion too. |
XhmikosR
reviewed
Dec 27, 2022
GeoSot
reviewed
Dec 31, 2022
GeoSot
reviewed
Dec 31, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed your example
Motivation & Context
Change is required for toast work without glitches.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Fixes #33906