Check for maxScroll, it isn't always ready at initial load of the page, ...#3767
Closed
erotte wants to merge 1 commit intotwbs:masterfrom
erotte:patch-1
Closed
Check for maxScroll, it isn't always ready at initial load of the page, ...#3767erotte wants to merge 1 commit intotwbs:masterfrom erotte:patch-1
erotte wants to merge 1 commit intotwbs:masterfrom
erotte:patch-1
Conversation
…e, so the last nav entry is marked by default in 90% of page loads (current Safari, Chrome, FF on OSX )
Member
|
we only accept pull requests against wip branches - also please provide a unit test if possible. thanks! |
|
Thanks, this fixed my problem.. |
This was referenced Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...so the last nav entry is marked by default in 90% of page loads (current Safari, Chrome, FF on OSX )