Docs: replace twbs/bootstrap-npm-starter by twbs/examples/tree/main/icons-font#37671
Merged
Docs: replace twbs/bootstrap-npm-starter by twbs/examples/tree/main/icons-font#37671
twbs/bootstrap-npm-starter by twbs/examples/tree/main/icons-font#37671Conversation
81eba32 to
6ce7485
Compare
twbs/bootstrap-npm-starter by twbs/examples/tree/main/icons-font
Member
|
I think https://github.com/twbs/examples/tree/main/sass-js or https://github.com/twbs/examples/tree/main/sass-js-esm is a better fit here instead of the Icons example which doesn't compile Bootstrap's source Sass code at all. Thoughts? |
Member
Author
|
I can replace in this PR https://github.com/twbs/examples/tree/main/icons-font with https://github.com/twbs/examples/tree/main/sass-js as suggested and in a second time recreate the starter template in https://github.com/twbs/examples which is mayble more complete? |
6ce7485 to
58ab6bf
Compare
Member
|
Updated it to replace the links as mentioned. Also updated the starter template's CSS, so this is now dependent on the icon link addition, and fixes the |
58ab6bf to
4353a07
Compare
4353a07 to
9649f86
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap 4 is EOL in few weeks.
It means that https://github.com/twbs/bootstrap-npm-starter shouldn't be referenced anymore in our latest documentation. And that it could probably by archived.
This PR suggested that all references to https://github.com/twbs/bootstrap-npm-starter are changed to use the closest already existing example we have... and it seems to be https://github.com/twbs/examples/tree/main/icons-font.
This PR also suggest to update the Starter template example page to add references to our other examples.
This version tries not to modify too much wording and references by keeping the notion of "npm started" even if our example is rather named "Bootstrap Icons", but we can go further.
/cc @mdo
Type of changes
Checklist
npm run lint)Live previews