Merged
Conversation
* set an explicit `aria-label` to the switcher (as the `<span>` is not sufficient, as it can be display:none'd and then the button has no accName) * make the theme buttons actual `aria-pressed` toggles
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
patrickhlauke
force-pushed
the
patrickhlauke-docs-theme-switcher-accessibility
branch
from
08db223 to
04bde56
Compare
patrickhlauke
force-pushed
the
patrickhlauke-docs-theme-switcher-accessibility
branch
from
04bde56 to
304202e
Compare
this way, if the text ever gets changed in the html, this will adapt appropriately
patrickhlauke
changed the title
This was referenced Jan 2, 2023
Closed
krzysdz
added a commit
to krzysdz/inz
that referenced
this pull request
Jan 16, 2023
This commit mirrors twbs/bootstrap#37780 with ~~a small fix~~ a fix from twbs/bootstrap#37836 and adds the missing checkmark icon to the theme dropdown.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aria-labelto the switcher (as the<span>is not sufficient, as it can be display:none'd and then the button has no accName); also include the currently selected theme namearia-pressedtoggles, so the currently active one is explicitly announcedMotivation & Context
Make sure our docs controls are accessible. Surprised this was pushed to live in the current state.
Video (using Chrome/NVDA) showing the current state, and the fixed version with this PR applied
bootstrap-theme-switcher.mp4
Note how in the current state, the button (when the text is not visible) lacks an accessible name (just announced as "button"), the currently selected theme button is not identified by screen readers, and once choosing a theme, focus is just lost/rugpulled.
Type of changes
Checklist
npm run lint)Live previews
https://deploy-preview-37780--twbs-bootstrap.netlify.app/