Fix duplicate --bs-emphasis-color set value

[julien-deramond]

Description

--bs-emphasis-color is set 2 times in scss/_root.scss; 1 time with $body-emphasis-color and 1 time with $emphasis-color.

I supposed that the last is the right one based on what we fixed recently on dark mode (having a white color instead of $gray-100) so this PR suggests to have --bs-emphasis-color based on $emphasis-color on light mode and $emphasis-color-dark in dark mode.

It means that $body-emphasis-color and $body-emphasis-color-dark become useless and can be dropped.

@mdo I let you double-check if the rendering is not broken and if this is the way you thought the Sass/CSS vars. We can keep $body-emphasis-color* and remove $emphasis-color* if that makes more sense to you.

Type of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have read the contributing guidelines
• My code follows the code style of the project (using npm run lint)
• (NA) My change introduces changes to the documentation
• (NA) I have updated the documentation accordingly
• (NA) I have added tests to cover my changes
• All new and existing tests passed

Live previews

• https://deploy-preview-37809--twbs-bootstrap.netlify.app/

[mdo]

Pushed a change to do the reverse. I included the body to first imply that this is an emphasis against the default body text, and second to match the naming of our new body-secondary and body-tertiary names.

Thanks for catching though!

[doughlass]

@mdo I'm trying to rattle my brain to understand why the following was overwritten on scss/_root.scss.

@each $name, $value in $grid-breakpoints {
    --#{$prefix}breakpoint-#{$name}: #{$value};
  }

The code was merged back in October 2022 via #36095 and I've gone through commit history and found that this pull request changes the content what was already on _root.scss.

Please can we get this $grid-breakpoints back in as it was previously intended.