Merged
Conversation
Closed
81 tasks
Member
|
Oh this looks great! Just reviewed in my phone, will check more closely on laptop later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests to display slightly differently the colors in the second part of the table in https://getbootstrap.com/docs/5.3/customize/color/#colors so that:
--bs-xxx,--bs-xxx-rgband--bs-xxx-bg-subtleare displayed as background colors--bs-xxx-border-subtleis displayed as a big border--bs-xxx-textis displayed as an actual textMotivation & Context
We struggled to understand this table with @louismaximepiton when he was trying to find a dark/black text color for another PR.
When you have such a goal in mind and that you can directly in https://getbootstrap.com/docs/5.3/customize/color/#colors, there's
--bs-dark-textand the text is displayed as white. IMO it's very hard to understand.Type of changes
Checklist
npm run lint)Live previews