Skip to content

Docs: Deprecate the Sass var and remove any occurence of the .text-muted#37890

Merged
mdo merged 1 commit intotwbs:mainfrom
louismaximepiton:main-lmp-remove-text-muted
Jan 16, 2023
Merged

Docs: Deprecate the Sass var and remove any occurence of the .text-muted#37890
mdo merged 1 commit intotwbs:mainfrom
louismaximepiton:main-lmp-remove-text-muted

Conversation

@louismaximepiton
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton commented Jan 16, 2023

Description

Remove occurences of .text-muted in the doc to replace them by .text-body-secondary.
Deprecate the Sass variable $text-muted.

Motivation & Context

Following the dark mode, removing the references to .text-muted and $text-muted.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, nice!

@mdo mdo merged commit 9042efd into twbs:main Jan 16, 2023
@louismaximepiton louismaximepiton deleted the main-lmp-remove-text-muted branch January 17, 2023 07:36
@mdo mdo mentioned this pull request Apr 9, 2023
3 tasks
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants