Skip to content

CSS: Proposal to rename the CSS and Sass variables for .*-text-emphasis#37907

Merged
mdo merged 1 commit intotwbs:mainfrom
louismaximepiton:main-lmp-sass-rename
Jan 21, 2023
Merged

CSS: Proposal to rename the CSS and Sass variables for .*-text-emphasis#37907
mdo merged 1 commit intotwbs:mainfrom
louismaximepiton:main-lmp-sass-rename

Conversation

@louismaximepiton
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton commented Jan 17, 2023

Description

Rename Sass and CSS variables *-text to *-text-emphasis.

Motivation & Context

Have some consistency between the variables and the classes used.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig. Thanks!

@mdo mdo merged commit 15744ee into twbs:main Jan 21, 2023
@louismaximepiton louismaximepiton deleted the main-lmp-sass-rename branch January 23, 2023 07:22
@cccabinet cccabinet mentioned this pull request Feb 5, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants