Conversation
…de adaptive theme values
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revamps our new text emphasis, subtle border color, and subtle background colors. Instead of manually using specific darker or lighter shades (e.g.,
$blue-300for subtle primary border), they're now generated based on theme colors using the existingtint-color()andshade-color(). This is the more sensible approach given feedback in #37949.This purposely avoids touching the grays for now—too annoying to tweak right now. Down the line in v6, I think we can revamp some theme colors, too:
$secondaryto allow for newbody-secondaryandbody-tertiaryapproach in our CSS vars and utilities.accentcolor that complements primary.Might be more coming for that as well.
Fixes #37949.