Skip to content

Attempt to fix focus ring being cut off in table of contents#37965

Merged
mdo merged 3 commits intomainfrom
toc-focus
Feb 14, 2023
Merged

Attempt to fix focus ring being cut off in table of contents#37965
mdo merged 3 commits intomainfrom
toc-focus

Conversation

@mdo
Copy link
Copy Markdown
Member

@mdo mdo commented Jan 28, 2023

Potential alternative to #37940.

/cc @patrickhlauke

@mdo mdo requested a review from a team as a code owner January 28, 2023 08:18
@patrickhlauke
Copy link
Copy Markdown
Member

This also works, sure. I wasn't sure whether not having the little left-hand border on the active item on medium size was intentional or not, so my approach kept that behaviour (hence the need for the media queries). This is obviously much more straightforward, and keeps the left-hand border at medium, large, and extra large sizes

@mdo mdo merged commit 9dd42e1 into main Feb 14, 2023
@mdo mdo deleted the toc-focus branch February 14, 2023 16:58
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants