Closed
Conversation
fix validation color. the "sucess-text" and "danger-text" not more defined set back to default color-
Member
mdo
reviewed
Feb 13, 2023
| $form-validation-states: ( | ||
| "valid": ( | ||
| "color": var(--#{$prefix}success-text), | ||
| "color": var(--#{$prefix}success), |
Member
There was a problem hiding this comment.
This should probably be changed to the -emphasis variables so that it adapts to color modes.
Suggested change
| "color": var(--#{$prefix}success), | |
| "color": var(--#{$prefix}success-text-emphasis), |
Member
There was a problem hiding this comment.
With the *-text-emphasis version, the dark mode looks good
But it's very difficult to see the colors (too dark IMO) in light mode. But maybe it's because I'm used to the old color.
Member
|
Opened another PR at #38044 to maybe tackle this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix validation color. the "sucess-text" and "danger-text" not more defined set back to default color-
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Before
https://deploy-preview-38034--twbs-bootstrap.netlify.app/docs/5.3/forms/validation/#custom-styles
After
https://deploy-preview-38041--twbs-bootstrap.netlify.app/docs/5.3/forms/validation/#custom-styles
Related issues