Fix console error in examples pages due to no theme switcher#38074
Merged
Fix console error in examples pages due to no theme switcher#38074
Conversation
XhmikosR
approved these changes
Feb 17, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR checks in
color-mode.jsthat thethemeSwitchervar is notnullbefore continuing the algorithm.Motivation & Context
This avoids an error message in the console when one goes to any examples in our doc (e.g. https://twbs-bootstrap.netlify.app/docs/5.3/examples/heroes/) either in light or dark mode:
This is because our examples react to the theme being light or dark via
color-modes.js, but they don't have any dropdown switcher on the page (like in the header for other pages).Type of changes
Checklist
npm run lint)Live previews