Drop duplicate $nav-link-disabled-color declaration#38083
Merged
julien-deramond merged 2 commits intomainfrom Feb 23, 2023
Merged
Drop duplicate $nav-link-disabled-color declaration#38083julien-deramond merged 2 commits intomainfrom
$nav-link-disabled-color declaration#38083julien-deramond merged 2 commits intomainfrom
Conversation
mdo
approved these changes
Feb 22, 2023
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Should definitely be the new CSS variable. Thanks!
julien-deramond
deleted the
main-jd-drop-duplicate-nav-disabled-color-init
branch
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests dropping one of the two
$nav-link-disabled-color. I supposed that we prefer to set it with the CSS var instead of$gray-500based on our recent work around color mode. But I might be wrong; there are some edge cases sometimes :)Type of changes
Checklist
npm run lint)Live previews