Docs: consistent usage of CSS sections#38175
Merged
julien-deramond merged 2 commits intomainfrom Mar 13, 2023
Merged
Conversation
4089196 to
7d7583d
Compare
20 tasks
Member
|
I think some are missing in:
We should also unify our |
Member
Author
|
Yep, this is what I've mentioned in the description, in the warning message. This PR treats only the things I'm sure about but I can modify the rest of it of course if we state exactly what direction we want to take. @mdo thoughts here? |
mdo
approved these changes
Mar 10, 2023
Member
|
@julien-deramond If you want to update those other pages, including the API heading, feel free! |
Member
Author
|
So I'm merging this one already reviewed and I'll create another PR so that I can suggest something. |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on 20ab821 and our recent modifications around custom properties, some sections are sometimes called Sass, Sass variables, CSS, etc.
Based on similar files in these folders, this PR suggests modifications to have consistent "CSS" + "Sass variables" sections in:
/components/content/formsBased on similar files in these folders, this PR suggests modifications to have consistent "Sass mixins" sections in:
/componentsBased on similar files in these folders, this PR suggests modifications to have consistent "Sass loop" sections in:
/componentsType of changes
Checklist
npm run lint)Live previews