Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples#38182
Merged
Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples#38182
Conversation
Co-authored-by: Julien Déramond <juderamond@gmail.com>
mdo
approved these changes
Mar 10, 2023
Member
|
Thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dataattribute on a button" changed to "Dismissal can be achieved with thedata-bs-dismissattribute on a button" for more understandable indicationdata-bs-target" changed to "using the additionaldata-bs-target" for more complete indicationbtn-closetobtn btn-primarysince an outside button is unlikely to be a cross buttonMotivation & Context
Makes the documentation more understandable and precise.
Type of changes
Checklist
npm run lint)Live previews