Skip to content

Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples#38182

Merged
mdo merged 3 commits intotwbs:mainfrom
hannahiss:main-his-btn-close-triggers
Mar 10, 2023
Merged

Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples#38182
mdo merged 3 commits intotwbs:mainfrom
hannahiss:main-his-btn-close-triggers

Conversation

@hannahiss
Copy link
Copy Markdown
Contributor

@hannahiss hannahiss commented Mar 7, 2023

Description

  • "Dismissal can be achieved with the data attribute on a button" changed to "Dismissal can be achieved with the data-bs-dismiss attribute on a button" for more understandable indication
  • "using the data-bs-target" changed to "using the additional data-bs-target" for more complete indication
  • change outside button class from btn-close to btn btn-primary since an outside button is unlikely to be a cross button

Motivation & Context

Makes the documentation more understandable and precise.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Comment thread site/layouts/shortcodes/js-dismiss.html Outdated
Co-authored-by: Julien Déramond <juderamond@gmail.com>
@mdo
Copy link
Copy Markdown
Member

mdo commented Mar 10, 2023

Thanks!

@mdo mdo merged commit fd7cfac into twbs:main Mar 10, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants