Conversation
Member
|
I haven't checked the code nor what would be the impact in terms of accessibility around But I'm so happy to be able in this PR to do what I did before: clicking anywhere in the page, then Tab, then the closest element is focused. TBH it's a nightmare to test visible focus without this behavior since the focus on the main page goes back to the main navbar each time; I had to use this new "trick": click on the copy button and Shift + Tab 😄 |
Member
|
i actually have no idea why we'd have a |
patrickhlauke
approved these changes
Mar 9, 2023
mdo
approved these changes
Mar 10, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
tabindex="0"from the body.Make the scrollspy documentation evolve a bit.
Motivation & Context
Make the focus on a specific element of the doc hard.
Small check:
TabThe main branch leads to skip links wherever you selected the word.
The preview leads to the next element.
As far as I can see, the body is still accessible from keyboard.
Type of changes
Checklist
npm run lint)Live previews
Related issues
NA.