Skip to content

Guard more in color-modes.js#38235

Merged
XhmikosR merged 2 commits intomainfrom
XhmikosR-patch-2
Mar 14, 2023
Merged

Guard more in color-modes.js#38235
XhmikosR merged 2 commits intomainfrom
XhmikosR-patch-2

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Mar 14, 2023

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR marked this pull request as ready for review March 14, 2023 14:18
@XhmikosR XhmikosR requested a review from a team as a code owner March 14, 2023 14:18
@XhmikosR XhmikosR merged commit 474bf2a into main Mar 14, 2023
@XhmikosR XhmikosR deleted the XhmikosR-patch-2 branch March 14, 2023 18:30
@mdo
Copy link
Copy Markdown
Member

mdo commented Mar 20, 2023

This needs to be reverted, it breaks the color mode toggle.

mdo added a commit that referenced this pull request Mar 20, 2023
mdo added a commit that referenced this pull request Mar 20, 2023
@XhmikosR XhmikosR added the skip-changelog So that the release drafter action doesn't include it label Mar 20, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs js skip-changelog So that the release drafter action doesn't include it v5

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants