Docs: consistent deprecation messages in Close Button dark variant#38247
Merged
Docs: consistent deprecation messages in Close Button dark variant#38247
Conversation
mdo
approved these changes
Mar 16, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several dark variants of components are deprecated in v5.3.0.
Close button message regarding this deprecation is not correctly aligned with the one from the dark carousels for example (see https://twbs-bootstrap.netlify.app/docs/5.3/components/carousel/#dark-variant).
This PR suggests to:
deprecated-inshortcodeinfotowarningMotivation & Context
Consistency in the doc.
Type of changes
Checklist
npm run lint)Live previews