Skip to content

Update Vite, Parcel and Webpack guides#38305

Merged
XhmikosR merged 5 commits intomainfrom
main-jd-update-vite-parcel-webpack-guides
Mar 23, 2023
Merged

Update Vite, Parcel and Webpack guides#38305
XhmikosR merged 5 commits intomainfrom
main-jd-update-vite-parcel-webpack-guides

Conversation

@julien-deramond
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond commented Mar 22, 2023

Description

Based on the recent modifications that happened in the examples repo, I've updated Vite, Parcel and Webpack guides to match the new configurations.

/cc @XhmikosR

Parcel

  • Dropped the tildes

Vite

  • Added a build part to the vite.config.js file
  • Moved the <script> tag in the index.html file into the <head>
  • Dropped the first step of "Import Bootstrap" section as it's not needed anymore
  • Rewrote the second step for consistency with Parcel guide for instance
  • Dropped the tildes

Webpack

  • Added the new html-webpack-plugin dependency and a sentence to explain it
  • Changed the commands to create the project folder and files
  • Changed the webpack.config.js file to match the new one in examples repository
  • Don't use dist/index.html anymore but src/index.html instead
  • Regenerated the diffs linked to miniCssExtractPlugin

Motivation & Context

Consistency across the docs and the examples repo.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond force-pushed the main-jd-update-vite-parcel-webpack-guides branch from 0891f09 to 11b36ad Compare March 22, 2023 18:49
@julien-deramond julien-deramond marked this pull request as ready for review March 22, 2023 18:51
Comment thread site/content/docs/5.3/getting-started/webpack.md
Comment thread site/content/docs/5.3/getting-started/webpack.md
@XhmikosR XhmikosR merged commit 99867eb into main Mar 23, 2023
@XhmikosR XhmikosR deleted the main-jd-update-vite-parcel-webpack-guides branch March 23, 2023 06:07
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants