Fix carousel when color-mode-type is media-query#38325
Closed
Fix carousel when color-mode-type is media-query#38325
Conversation
Author
|
What would be the best way to add an automated test case for this? I had a quick look but couldn't immediately figure it out. I don't think the Jasmine tests can do this, because it's not actually compiling the whole SCSS. Basically we want to compile the SCSS with a different set of variables. If there's a good example and I missed it, let me know and I'll follow up. |
Member
Author
|
Thanks @julien-deramond, I understand how this can be done now.
|
Member
|
I didn't see this PR before creating mine, but wanted to share that I prefer the combined selector output from #38328 over this option. I'll go ahead and close this out and we'll plan to ship that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Bug: #38322
This adds a trivial condition to apply #38209 only when @color-mode-type=dark.
Motivation & Context
It fixes #38322.
Type of changes
Checklist
npm run lint)Live previews
Related issues