Skip to content

Docs: fix table with empty column#38342

Merged
julien-deramond merged 1 commit intotwbs:mainfrom
hannahiss:main-his-bug-modal-table-a11y
Mar 27, 2023
Merged

Docs: fix table with empty column#38342
julien-deramond merged 1 commit intotwbs:mainfrom
hannahiss:main-his-bug-modal-table-a11y

Conversation

@hannahiss
Copy link
Copy Markdown
Contributor

@hannahiss hannahiss commented Mar 27, 2023

Description

Removing an empty column in "Fullscreen Modal" (maybe leftover documentation?)

Motivation & Context

Empty columns are a bad pattern for accessibility (blank table column header)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@hannahiss hannahiss marked this pull request as ready for review March 27, 2023 08:42
@julien-deramond julien-deramond merged commit 31f93e2 into twbs:main Mar 27, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Ready to merge

Development

Successfully merging this pull request may close these issues.

2 participants