Merged
Conversation
XhmikosR
approved these changes
Mar 28, 2023
XhmikosR
changed the title
<script> from index.html in Webpack guide
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/twbs/examples/pull/136/files introduced the removal of
<script src="./main.js"></script>since Webpack handles it on its own. So this PR updates the Webpack guide to remove this<script>part as well.https://github.com/twbs/examples/pull/138/files introduced a new way to build the Webpack tutorial with the
--mode=production. So this PR updates the Webpack guide to introduce it as well.Motivation & Context
Consistency between the docs and the
twbs/examplesrepository.Type of changes
Checklist
npm run lint)Live previews