Skip to content

Modal: drop loop#38368

Merged
XhmikosR merged 1 commit intomainfrom
xmr/js-modal-drop-loop
Mar 29, 2023
Merged

Modal: drop loop#38368
XhmikosR merged 1 commit intomainfrom
xmr/js-modal-drop-loop

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Mar 29, 2023

We only have two elements to iterate over so it doesn't make a lot of sense to use a loop here

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

We only have two elements to iterate over so it doesn't make a lot of sense to use a loop here
@XhmikosR XhmikosR added the js label Mar 29, 2023
@XhmikosR XhmikosR marked this pull request as ready for review March 29, 2023 07:54
@XhmikosR XhmikosR requested a review from a team as a code owner March 29, 2023 07:54
@XhmikosR XhmikosR merged commit 7a7fc1a into main Mar 29, 2023
@XhmikosR XhmikosR deleted the xmr/js-modal-drop-loop branch March 29, 2023 08:00
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants