Skip to content

Fix uneditable input border#3884

Closed
spantaleev wants to merge 1 commit intotwbs:2.1.0-wipfrom
spantaleev:fix-uneditable-input-border
Closed

Fix uneditable input border#3884
spantaleev wants to merge 1 commit intotwbs:2.1.0-wipfrom
spantaleev:fix-uneditable-input-border

Conversation

@spantaleev
Copy link
Copy Markdown
Contributor

Before: http://i.imgur.com/qYLgJ.png
After: http://i.imgur.com/yxAa1.png

Notice the #eee left borders in cases 2 and 4 on the before screenshot.

Chris-Jones-Gill added a commit to Chris-Jones-Gill/bootstrap that referenced this pull request Jun 19, 2012
Add js tooltip function so a tooltip can be called without using rel=
Update tooltip html to reflect new js function
Include changes from twitter/bootstrap issue twbs#3888
Include changes from twitter/bootstrap issue twbs#3885
Include changes from twitter/bootstrap issue twbs#3884
Include changes from twitter/bootstrap issue twbs#3880
Include changes from twitter/bootstrap issue twbs#3878
Include changes from twitter/bootstrap issue twbs#3876
Include changes from twitter/bootstrap issue twbs#3875
@mdo
Copy link
Copy Markdown
Member

mdo commented Jun 21, 2012

Double check this against the tests that are in 2.1.0-wip, available locally at /bootstrap/less/tests/css-tests.html. It introduces some regressions.

@spantaleev
Copy link
Copy Markdown
Contributor Author

My environment was contaminated by styles from https://github.com/addyosmani/jquery-ui-bootstrap, which not only provide a jQuery UI theme but also override Twitter Bootstrap styles (for .uneditable-input and others). My fix works if you use the mess created by both.

This pull request is invalid, although there is another problem with uneditable-input that resides in a container with both input-append and input-prepend (as your newly added test in 9aa5a6d illustrates). I'll open a new pull request for that.

@spantaleev spantaleev closed this Jun 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants