fixed Please adjust default table-striped color when dark mode is active Fixes#39032
Closed
Mahendrareddy190 wants to merge 1 commit intotwbs:mainfrom
Mahendrareddy190:fix/table_in_dark_mode
Closed
fixed Please adjust default table-striped color when dark mode is active Fixes#39032Mahendrareddy190 wants to merge 1 commit intotwbs:mainfrom Mahendrareddy190:fix/table_in_dark_mode
Mahendrareddy190 wants to merge 1 commit intotwbs:mainfrom
Mahendrareddy190:fix/table_in_dark_mode
Conversation
Mahendrareddy190
changed the title
Member
|
Hey, Thanks a lot for your contribution. I think your solution, might introduce an issue for the doc in light mode. And it doesn't resolve the issue you mentionned since people still want to use standard tables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39029
Description
The comment suggests that there was a problem related to readability in the Dark mode of a table. In Dark mode, the background might have been too dark, making it difficult for users to distinguish the table text from the background. This lack of contrast can lead to an uncomfortable user experience and hinder accessibility.
so, I have added the table-dark to tables.
By incorporating the table-dark class, developers aim to enhance the user experience, especially when the application is being used in Dark mode. This change promotes accessibility and ensures that users can easily read and interact with the table's content, regardless of the chosen color scheme.
Before:
After:-