New Sass var $btn-link-focus-shadow-rgb to allow customisation#39119
Merged
julien-deramond merged 2 commits intotwbs:mainfrom Sep 13, 2023
Merged
New Sass var $btn-link-focus-shadow-rgb to allow customisation#39119julien-deramond merged 2 commits intotwbs:mainfrom
$btn-link-focus-shadow-rgb to allow customisation#39119julien-deramond merged 2 commits intotwbs:mainfrom
Conversation
louismaximepiton
requested changes
Aug 30, 2023
Member
louismaximepiton
left a comment
There was a problem hiding this comment.
Something has to be rethought in order not to increase the bundles size too much.
Contributor
Author
That's fair. I'm going to simply introduce a new Sass variable then, as you suggested: |
btn-link-focus-shadow-rgb to allow customisation between color modes$btn-link-focus-shadow-rgb to allow customisation
7ad8e47 to
4e41020
Compare
4e41020 to
7e10239
Compare
julien-deramond
approved these changes
Sep 13, 2023
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
This was referenced May 19, 2024
This was referenced Oct 2, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
$btn-link-focus-shadow-rgbso that users can customise focus shadow for.btn-link.Motivation & Context
Right now, for
.btn-link, it's generated using only$link-color.This might be undesirable and there should be an easy way to override it (e.g. users might want to change how it's calculated, or have specific design requirements that differ between light/dark theme).
Type of changes
Checklist
npm run lint)Live previews