Sass warning: Handle the error directly in the function#39132
Sass warning: Handle the error directly in the function#39132louismaximepiton wants to merge 1 commit intomainfrom
Conversation
|
I couldn't achieve to resolve the CI (node-sass), I'll try some more asap. |
|
This is not an issue, except for "dart-sass," and "dart-sass" is no standard or anything relevant at all. So don't waste your precious time trying to adapt this project to it. Let's stick to node-sass and dedicate to make this project continue to be the work of art that it is. |
Node Sass has been deprecated for almost three years, and Dart Sass is the primary implementation of Sass which is officially recommended for use (see https://sass-lang.com/dart-sass/). |
|
As long as we want to maintain compatibility with node-sass, I'm not sure we can find a solution here. At some point (in v6?), maybe we can stop maintaining this compatibility and then land such a fix within the function. |
|
I'm fine with this on my side. Let's try to not forget it in v6. |
|
Closing it for now. We'll get back to it for v6. |
Description
Add a check for percentage values directly in the function so people using this function won't have any change to do.
Changed the rfs vendor as well, but it might be done on rfs side directly and backported in Bootstrap.
Motivation & Context
Deprecation warning while using percentage values in
abs()function.Type of changes
Checklist
npm run lint)Related issues
Fixes #39028.
Might superseed #39030.