docs: add aria-hidden='true' to decorative SVGs#40686
Merged
julien-deramond merged 1 commit intomainfrom Aug 2, 2024
Merged
Conversation
patrickhlauke
approved these changes
Aug 2, 2024
Member
patrickhlauke
left a comment
There was a problem hiding this comment.
In general, aria-hidden="true" should not be required when there's nothing inside the svg that would lead to an announcement - like an actual text node, or things like <title> or <desc>. normally, SRs should be treating these svgs like they do a bunch of empty and semantically neutral <div>s and <span>s. but it also doesn't do any harm adding it just in case, belt and braces. so I'm ok with this.
5 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
aria-hidden="true"to decorative SVGs so they remain hidden from assistive technologies:Please note that
site/layouts/partials/icons/circle-square.svgandsite/layouts/partials/icons/droplet-fill.svgare only used as decorative SVGs so thearia-hidden="true"was added directly to the SVG files.This PR also removes some remaining
focusable="false"as it was mentioned in #37498 (comment) that (and I agree) it's not necessary "to cater to IE since it's now been officially deprecated by Microsoft, and that was the only browser exhibiting this odd behaviour."Type of changes
Checklist
npm run lint)Live previews