bug: Fix Incorrect comparison in color-contrast function#41551
Closed
viniciusvts wants to merge 1 commit intotwbs:mainfrom
Closed
bug: Fix Incorrect comparison in color-contrast function#41551viniciusvts wants to merge 1 commit intotwbs:mainfrom
viniciusvts wants to merge 1 commit intotwbs:mainfrom
Conversation
Refs: 41543 Closes: 41543
Member
|
Could you please provide some before-and-after examples, including comparisons with other tools that implement this WCAG algorithm? This would help us review the proposed update. Please note that the need for updating the algorithm has not yet been discussed in the corresponding issue. |
Member
|
Closing as superseded by #41585 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the conditional to correctly reflect the WCAG standard: the visual presentation of text and images of text has a contrast ratio of at least 4.5:1 (i.e., >= 4.5), not strictly greater than (>).
Type of changes
Checklist
npm run lint)Refs: #41543
Closes: #41543