Dropdown button in dev branch#467
Conversation
There was a problem hiding this comment.
Is this inline-block for just .dropdown that surrounds the buttons? If so, let's just pull that out and only put it on the .dropdown if possible.
There was a problem hiding this comment.
I didn't do that as I figured that li.menu was for backwards compatibility and eventually would be removed, but no problem I'll pull it out.
|
Nice, much better merge here :). Taking a look at this in more detail now. I think the HTML and CSS can get merged in no problem, but I'm going to get @fat's opinion on the JS afterwards. |
|
In my notification area (and email) I can se that you made 3 comments, however I can only see one her https://github.com/twitter/bootstrap/pull/467/files, did you change your mind or I'm I looking in the wrong place? |
|
Yeah, I deleted a few of them. They're small enough I can make them. Only one bug stopping me from working on integrating this now: looks like in Chrome (at least) we have a horizontal scroll bar. Looks like something isn't closing around the topbar/navigation section. Take a look and resolve that please and I can get this in. |
|
An extra I also added an additional check for disabled state to the javascript, which didn't make it over in my first move to the dev branch. |
|
@kasperp, just pushed a new temp branch, kasperp-dropdown-btn-dev, that implements this with some adjustments to make it a bit more straightforward to style. Also segments btn dropdowns from regular dropdowns and adds a lot of comments. Take a look at let me know if anything stands out. |
|
Also, IE7 no likey. Diving in to see if I can make it work... |
|
@markdotto that looks great. I really must improve my comment writing :-). As for the extra class Yeah - IE7 I haven't tested (sorry I should have mentioned that), great if you can make it work. |
|
Update: still haven't figured out a good way to handle IE7. Will swing back around to this in 2.0-wip. |
|
I'll try and give IE7 a go, when do you plan to release 1.4 ? |
|
"when its ready"? hopefully soon! its going to rock. |
|
@andriijas fair enough. I was looking for an approximation. If I'm going to give this IE7 issue a go before 1.4 I wanted an idea of the how long I had, 1 day, 1 week, 1 month .... |
|
hey i was just citing what I thought was coming as an answer :) i also wanna know... |
|
We'd like to release by Friday to get this out so we can focus on 2.0-wip. |
|
@markdotto, sounds great I'll try and give it ago before friday |
|
Had a quick look at the CSS. This may be unrelated but the IE6/7 inline-block hack usually needs |
|
I just noticed a difference between the pushed state in my version (dropdown-btn-dev) and your version (kasperp-dropdown-btn-dev). Mine Yours Was that intentionally or by accident ? As for the IE7 issue, I have run out of time this week. So I guess I have to wait for 2.0 for this, one more reason to hope for an early x-mas :-) |
|
I'm interested in seeing this make it into 1.4. If there's anything I can do to assist with testing or anything like that, please let me know. I have ready access to IE 7, IE 8, and IE 9 (though personally would take this feature with or without IE support). |
|
@derekprior as I just said I'm out of time this week. So if you can provide an IE7 fix that would be awesome. |
|
@markdotto I made a pull request (#573) to your kasperp-dropdown-btn-dev branch which I believe fixes the IE7 problem |
5 participants
Moved pull request 192 to dev branch