fix position of focused search in inverse navbar#4859
Closed
moesalih wants to merge 1 commit intotwbs:2.1.1-wipfrom
moesalih:2.1.1-wip
Closed
fix position of focused search in inverse navbar#4859moesalih wants to merge 1 commit intotwbs:2.1.1-wipfrom moesalih:2.1.1-wip
moesalih wants to merge 1 commit intotwbs:2.1.1-wipfrom
moesalih:2.1.1-wip
Conversation
When the search field in inverse navbar is focused, a small jump is size is noticable. This is due to changing the border and padding which is unnecessary.
Author
|
The issue can be seen in the bootstrap docs (http://twitter.github.com/bootstrap/components.html#navbar) under the Inverted variation section. Just select the search field and unselect it and you'll see the 1-pixel jump in size. |
Member
|
I see no jumping. What browser? |
Author
|
I tested latest Firefox and Chrome and It happens in both. It's a subtle 1-pixel increase in size, and just looks a little weird. If you want to see what this fix does, just disable the border and padding properties in the developer tools, and select/unselect the field, you'll see that it looks a little better. |
Member
|
The focused state is removing the border and increasing the padding, by 1px on all sides. It's an intentional change and one we'll keep for the time being. |
This was referenced Apr 26, 2021
This was referenced Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the search field in inverse navbar is focused, a small jump is size
is noticable. This is due to changing the border and padding which is
unnecessary.