Skip to content

Fixes for disabled elements in navbar and dropdowns#5034

Closed
gnrlwart wants to merge 2 commits intotwbs:masterfrom
gnrlwart:fixes_for_disabled
Closed

Fixes for disabled elements in navbar and dropdowns#5034
gnrlwart wants to merge 2 commits intotwbs:masterfrom
gnrlwart:fixes_for_disabled

Conversation

@gnrlwart
Copy link
Copy Markdown

@gnrlwart gnrlwart commented Sep 7, 2012

  • Fixed disabled dropdown submenus still showing on hover.
  • Fixed disabled links on a navbar still highlighting on hover or focus.
  • Darken disabled links on navbar.

Carl Glave added 2 commits September 7, 2012 11:12
- submenu showing and link highlight no longer happen of the .disabled
class is added to the dropdown-submenu.
- Links directly on a navbar will no longer highlight on hover if they
have the .disabled class on them.
@mdo
Copy link
Copy Markdown
Member

mdo commented Sep 11, 2012

Sorry, we cannot accept the not selector. Got anything else to use instead? Perhaps we just override?

@ljharb
Copy link
Copy Markdown

ljharb commented Sep 11, 2012

According to http://www.quirksmode.org/css/contents.html you should be able to use :enabled in IE8 and above, but that's got the same support as the :not selector.

@mdo
Copy link
Copy Markdown
Member

mdo commented Sep 18, 2012

Closing out. Please open a new pull request when feedback is addressed. Thanks!

@mdo mdo closed this Sep 18, 2012
@findchris
Copy link
Copy Markdown

Unless this has been addressed, it is an issue. Nav tabs still show hover effects even with disabled class applied to <li> element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants