fix: update release workflow to handle pre-release tags and commits c… #57
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions release workflow to handle pre-release tags differently from regular releases. The change adds conditional logic to distinguish between regular releases and pre-releases, creating separate workflows for each type.
Key Changes:
- Separates pre-release tag creation from regular release commit and tag creation
- Modifies existing steps to only run for non-pre-release versions
- Adds dedicated steps for pre-release tag creation and pushing
| - name: Create release commit and tag | ||
| if: ${{ github.event.inputs.dry_run == 'false' }} | ||
| if: ${{ github.event.inputs.dry_run == 'false' && needs.validate.outputs.is_prerelease == 'false' }} |
There was a problem hiding this comment.
Consider extracting the condition 'github.event.inputs.dry_run == 'false' && needs.validate.outputs.is_prerelease == 'false'' into a reusable variable or expression since it's repeated multiple times throughout the workflow. This would improve maintainability and reduce duplication.
| echo "Release commit and tag created" | ||
| - name: Create pre-release tag |
There was a problem hiding this comment.
[nitpick] The pre-release tag creation logic duplicates the VERSION variable assignment pattern used in other steps. Consider if this duplication could be reduced through workflow-level environment variables or job outputs.
…onditionally