Merged
Conversation
ktalebian
commented
Apr 28, 2021
|
|
||
| const getLatestPluginVersion = async (name: string): Promise<PluginVersionResource | null> => { | ||
| return versionsClient.latest(name); | ||
| try { |
Contributor
Author
There was a problem hiding this comment.
This was for e2e test the first time it runs.
Codecov Report
@@ Coverage Diff @@
## v4-beta #443 +/- ##
===========================================
+ Coverage 84.86% 84.91% +0.06%
===========================================
Files 144 144
Lines 3513 3526 +13
Branches 583 583
===========================================
+ Hits 2981 2994 +13
Misses 433 433
Partials 99 99
Continue to review full report at Codecov.
|
ahcai
reviewed
Apr 28, 2021
| ); | ||
| const list: string[] = option.addPlugins; | ||
| const list: string[] = []; | ||
| // = option.addPlugins; |
Contributor
Author
There was a problem hiding this comment.
Na gotta delete this actually. No longer used. The implementation has changed.
ktalebian
commented
Apr 29, 2021
packages/flex-plugins-api-toolkit/src/scripts/createConfiguration.ts
Outdated
Show resolved
Hide resolved
ahcai
approved these changes
Apr 29, 2021
This was referenced Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce load-order for enabling plugins: