Skip to content

Make windows not fail#446

Merged
ktalebian merged 4 commits intov4-betafrom
make-windows-not-fail
Apr 29, 2021
Merged

Make windows not fail#446
ktalebian merged 4 commits intov4-betafrom
make-windows-not-fail

Conversation

@ktalebian
Copy link
Copy Markdown
Contributor

  • Do not exit with code 1 on windows while we are fixing these tests

Copy link
Copy Markdown

@agupt agupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2021

Codecov Report

Merging #446 (81cef8c) into v4-beta (7b56292) will increase coverage by 84.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           v4-beta     #446       +/-   ##
============================================
+ Coverage         0   84.91%   +84.91%     
============================================
  Files            0      144      +144     
  Lines            0     3526     +3526     
  Branches         0      583      +583     
============================================
+ Hits             0     2994     +2994     
- Misses           0      433      +433     
- Partials         0       99       +99     
Impacted Files Coverage Δ
...lex-plugins-utils-exception/src/lib/TwilioError.ts 76.92% <0.00%> (ø)
...ages/flex-plugins-api-client/src/clients/client.ts 90.91% <0.00%> (ø)
...ages/flex-plugin-scripts/src/clients/pluginsApi.ts 100.00% <0.00%> (ø)
.../flex-plugin-builder-toolkit/src/scripts/deploy.ts 100.00% <0.00%> (ø)
...ages/flex-plugin-scripts/src/clients/baseClient.ts 100.00% <0.00%> (ø)
packages/flex-plugin-scripts/src/scripts/test.ts 97.62% <0.00%> (ø)
packages/flex-dev-utils/src/progress.ts 100.00% <0.00%> (ø)
packages/flex-dev-utils/src/lodash.ts 100.00% <0.00%> (ø)
...ns-api-toolkit/src/scripts/archiveConfiguration.ts 100.00% <0.00%> (ø)
packages/flex-dev-utils/src/logger.ts 100.00% <0.00%> (ø)
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b56292...81cef8c. Read the comment docs.

@ktalebian ktalebian merged commit 08adab8 into v4-beta Apr 29, 2021
@ktalebian ktalebian deleted the make-windows-not-fail branch April 29, 2021 23:04
pragya-arora added a commit that referenced this pull request Mar 18, 2026
Update all minimatch versions to patched releases. Add npm override
for minimatch@3.0.5 -> 3.1.5 since nx@15.8.5 pins it exactly.
Remaining versions updated via npm update (5.1.9, 8.0.7, 9.0.9).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants